New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scikit SVM implementation. #88

Merged
merged 7 commits into from Jul 13, 2017

Conversation

Projects
None yet
3 participants
@Iron-Stark
Contributor

Iron-Stark commented Jul 10, 2017

No description provided.

@rcurtin

Looks good, if you can address the single comment I think it is ready to go.

Show outdated Hide outdated methods/scikit/svm.py
Show outdated Hide outdated methods/scikit/svm.py
@Iron-Stark

This comment has been minimized.

Show comment
Hide comment
@Iron-Stark

Iron-Stark Jul 12, 2017

Contributor

@zoq

My local repo is a little messed up because of commiting shogun in master branch itself. Once that is merged I will make these changes in the other merged scikit PR's too.

Contributor

Iron-Stark commented Jul 12, 2017

@zoq

My local repo is a little messed up because of commiting shogun in master branch itself. Once that is merged I will make these changes in the other merged scikit PR's too.

@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq Jul 12, 2017

Member

Okay, so we should merge the shogun PR first?

Member

zoq commented Jul 12, 2017

Okay, so we should merge the shogun PR first?

@Iron-Stark

This comment has been minimized.

Show comment
Hide comment
@Iron-Stark

Iron-Stark Jul 12, 2017

Contributor

@zoq

Yes please.

Contributor

Iron-Stark commented Jul 12, 2017

@zoq

Yes please.

@rcurtin rcurtin merged commit c38c4fd into mlpack:master Jul 13, 2017

1 check passed

Benchmarks Checks Build finished.
Details

Iron-Stark added a commit to Iron-Stark/benchmarks that referenced this pull request Jul 14, 2017

Merge pull request mlpack#88 from Iron-Stark/patch-19
Update Scikit SVM implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment