New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MATLAB implementations. #94

Merged
merged 12 commits into from Jul 29, 2017

Conversation

Projects
None yet
3 participants
@Iron-Stark
Contributor

Iron-Stark commented Jul 19, 2017

@rcurtin @zoq

This is my final PR regarding MATLAB. Please review.

Merge pull request #89 from Iron-Stark/patch-20
Updating Matlab implementations
@Iron-Stark

This comment has been minimized.

Show comment
Hide comment
@Iron-Stark

Iron-Stark Jul 21, 2017

Contributor

@zoq @rcurtin

I have not used the AbsTol and MaxIter parameters here but I have facilitate specifying them. Whenever we update to later versions of MATLAB less edits would be required. If you want me to remove specifying those options please let me know.

Contributor

Iron-Stark commented Jul 21, 2017

@zoq @rcurtin

I have not used the AbsTol and MaxIter parameters here but I have facilitate specifying them. Whenever we update to later versions of MATLAB less edits would be required. If you want me to remove specifying those options please let me know.

@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq Jul 23, 2017

Member

@Iron-Stark sounds good for me, but we should add a comment, and note that the parameter are unused would be included once we use MATLAB2017.

Member

zoq commented Jul 23, 2017

@Iron-Stark sounds good for me, but we should add a comment, and note that the parameter are unused would be included once we use MATLAB2017.

Show outdated Hide outdated methods/matlab/RANDOMFOREST.m
Show outdated Hide outdated methods/matlab/RANDOMFOREST.m
Show outdated Hide outdated methods/matlab/SVR.m
Show outdated Hide outdated methods/matlab/SVR.m
@rcurtin

Thanks for the contribution; it looks like there is a lot of MATLAB we didn't originally benchmark, so it is nice to add it now. But I think I found a few problems---if you can take a look, I would appreciate it. :)

Show outdated Hide outdated methods/matlab/LASSO.m
Show outdated Hide outdated methods/matlab/svr.py
@zoq

zoq approved these changes Jul 28, 2017

Looks good for me, thanks!

@rcurtin

LGTM, thanks for the fixes. :)

@rcurtin rcurtin merged commit 1f67d07 into mlpack:master Jul 29, 2017

1 check passed

Benchmarks Checks Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment