Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic SPSA Initialization #74

Closed
coatless opened this issue Jan 20, 2019 · 4 comments

Comments

@coatless
Copy link
Contributor

commented Jan 20, 2019

With ensmallen 1.13.0 adding SPSA, there was a regression introduced. In particular, the SPSA initialization of parameters is set to some unknown value. This was picked up under the -Wreorder flag.

Details: https://stackoverflow.com/questions/1828037/whats-the-point-of-g-wreorder

Error Information:

* checking whether package 'RcppEnsmallen' can be installed ... WARNING
Found the following significant warnings:
  ../inst/include/ensmallen_bits/spsa/spsa.hpp:133:10: warning: 'ens::SPSA::Ak' will be initialized after [-Wreorder]
  ../inst/include/ensmallen_bits/spsa/spsa.hpp:123:10: warning:   'size_t ens::SPSA::maxIterations' [-Wreorder]
  ../inst/include/ensmallen_bits/spsa/spsa_impl.hpp:24:8: warning:   when initialized here [-Wreorder]
See 'd:/RCompile/CRANguest/R-release/RcppEnsmallen.Rcheck/00install.out' for details.

/ cc coatless/rcppensmallen#8

zoq added a commit to zoq/ensmallen that referenced this issue Jan 20, 2019

@zoq zoq referenced this issue Jan 20, 2019
@zoq

This comment has been minimized.

Copy link
Member

commented Jan 20, 2019

Thanks for the notification, #75 will fix the issue.

@coatless

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2019

@zoq that was quick! I almost had the PR ready.

@zoq

This comment has been minimized.

Copy link
Member

commented Jan 20, 2019

Will make sure to wait a couple of minutes before opening the PR :) Also, will make sure the build process marks similar issues in the future.

@rcurtin

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

Sorry for the slowness on this one. I merged #75 and released 1.13.1. Thanks for the report and feel free to open more issues for stuff like this in the future---it's pretty easy to fix. :)

@rcurtin rcurtin closed this Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.