Callbacks #119
Merged
Callbacks #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard to do with such crazy template metaprogramming...
Also fix memory handling bug.
Needs Armadillo sparse vectorise() support next.
Closed
|
If the BBSGD tests are failing and don't seem to be a part of this PR, we can open a separate issue for that. No need to hold this up on those; let me know what you think. 👍 |
tests/pso_test.cpp
Outdated
| double finalValue = f.Evaluate(coords); | ||
| REQUIRE(finalValue <= 1e-5); | ||
| for (size_t j = 0; j < 4; ++j) | ||
| REQUIRE(coords[j] <= 1e-3); |
There was a problem hiding this comment.
I recommend using the element accessor with bounds check here and in other code like this, ie. coords(j) instead of coords[j].
Since this is a test case, we should catch all possible errors. Using [] allows some errors to slip through.
There was a problem hiding this comment.
Ah, good point. I did a little regex-ery and here's a patch we can apply to this branch that makes this change for all tests:
There was a problem hiding this comment.
Great, will apply the patch.
rcurtin
approved these changes
Aug 29, 2019
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Signed-off-by: Marcus Edel <marcus.edel@fu-berlin.de>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #113; see #49 for more details.