Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callbacks #119

Merged
merged 91 commits into from Sep 4, 2019

Conversation

@zoq
Copy link
Member

commented Jun 2, 2019

This is based on #113; see #49 for more details.

rcurtin added 30 commits Jan 15, 2019
Make lines fit a little bit better.
Hard to do with such crazy template metaprogramming...
Update BigBatchSGD, Eve, FTML, Padam, and part of IQN.
Needs Armadillo sparse vectorise() support next.
zoq added 17 commits Aug 3, 2019
@rcurtin

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

If the BBSGD tests are failing and don't seem to be a part of this PR, we can open a separate issue for that. No need to hold this up on those; let me know what you think. 👍

double finalValue = f.Evaluate(coords);
REQUIRE(finalValue <= 1e-5);
for (size_t j = 0; j < 4; ++j)
REQUIRE(coords[j] <= 1e-3);

This comment has been minimized.

Copy link
@conradsnicta

conradsnicta Aug 22, 2019

Contributor

I recommend using the element accessor with bounds check here and in other code like this, ie. coords(j) instead of coords[j].

Since this is a test case, we should catch all possible errors. Using [] allows some errors to slip through.

This comment has been minimized.

Copy link
@rcurtin

rcurtin Aug 28, 2019

Member

Ah, good point. I did a little regex-ery and here's a patch we can apply to this branch that makes this change for all tests:

https://gist.github.com/e70df70cdb56072d28940ec197ba8036

This comment has been minimized.

Copy link
@zoq

zoq Aug 30, 2019

Author Member

Great, will apply the patch.

@rcurtin
Copy link
Member

left a comment

This is a huge PR but from my view I think everything is ready. Once this is merged, I'll go ahead and release ensmallen 2.10.0.

@mlpack-bot
mlpack-bot bot approved these changes Aug 30, 2019
Copy link

left a comment

Second approval provided automatically after 24 hours. 👍

rcurtin and others added 4 commits Aug 28, 2019
Use operator() not operator[] for bounds checks.
Signed-off-by: Marcus Edel <marcus.edel@fu-berlin.de>

@zoq zoq merged commit 45efb3e into mlpack:master Sep 4, 2019

2 checks passed

Static Code Analysis Checks Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rcurtin rcurtin referenced this pull request Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.