Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fast solve #127

Merged
merged 1 commit into from Sep 7, 2019

Conversation

@conradsnicta
Copy link
Contributor

commented Sep 5, 2019

use the fast solver; the default iterative refinement in solve() is an overkill in these cases

conrad
@zoq
zoq approved these changes Sep 5, 2019
Copy link
Member

left a comment

Looks good to me, I guess there are a couple of lines we could update since we bumped the version.

@mlpack-bot
mlpack-bot bot approved these changes Sep 6, 2019
Copy link

left a comment

Second approval provided automatically after 24 hours. 👍

@rcurtin
rcurtin approved these changes Sep 7, 2019
Copy link
Member

left a comment

Nice improvement! 👍

@rcurtin rcurtin merged commit d0cd0da into mlpack:master Sep 7, 2019

2 checks passed

Static Code Analysis Checks Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.