Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor compatibility fixes for ensmallen 1.x #131

Merged
merged 3 commits into from Sep 9, 2019

Conversation

@rcurtin
Copy link
Member

commented Sep 8, 2019

These simple fixes make it easier for older code to work with ensmallen 2.x. There's no functionality change (although GetInitialPoint() for LRSDP had a bug, and this fixes that).

@rcurtin

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2019

@mlpack-jenkins test this please

@rcurtin

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2019

@mlpack-jenkins test this please

@zoq
zoq approved these changes Sep 8, 2019
Copy link
Member

left a comment

Looks good to me.

@mlpack-bot
mlpack-bot bot approved these changes Sep 9, 2019
Copy link

left a comment

Second approval provided automatically after 24 hours. 👍

@rcurtin

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

The mlpack master build test will fail until mlpack/mlpack#2011 is merged, so I'll merge this here now, but release ensmallen 2.10.1 with the patch only after mlpack/mlpack#2011 is merged so that everyone's builds don't break.

(ensmallen-latest.tar.gz on the ensmallen website is currently temporarily linked to 1.16.2 so that everyone's mlpack builds, which automatically download ensmallen, don't break)

@rcurtin rcurtin merged commit 5a87d5a into mlpack:master Sep 9, 2019

2 of 3 checks passed

mlpack master build test Build finished.
Details
Static Code Analysis Checks Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rcurtin rcurtin deleted the rcurtin:compat-fixes branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.