Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParallelSGD omp fix #135

Merged
merged 4 commits into from Sep 26, 2019

Conversation

@zoq
Copy link
Member

commented Sep 14, 2019

zoq added 2 commits Sep 14, 2019
@zoq

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2019

@coatless have seen your message in IRC, do you see a similar issue as described in #132?

@coatless

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2019

@zoq we're running a different set of checks than the official tests. So #132 didn't pop up.

@zoq

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2019

I see, thanks for the clarification.

@rcurtin

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

@mlpack-jenkins test this please

Copy link
Member

left a comment

Looks good to me; if you want to update HISTORY.md feel free, otherwise I will do it during merge (while I make a release).

zoq added 2 commits Sep 25, 2019
@mlpack-bot
mlpack-bot bot approved these changes Sep 26, 2019
Copy link

left a comment

Second approval provided automatically after 24 hours. 👍

@zoq zoq merged commit d15772b into mlpack:master Sep 26, 2019
3 checks passed
3 checks passed
Static Code Analysis Checks Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mlpack master build test Build finished.
Details
@zoq

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2019

Let's start the matrix build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.