Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional test building #141

Merged
merged 2 commits into from Nov 10, 2019

Conversation

@robertohueso
Copy link
Member

robertohueso commented Nov 9, 2019

According to CMakeLists.txt

This project has no configurable options---it just installs the headers to the install location, and optionally builds the test program.

but it's not optional at the moment. This PR adds the option in CMake 馃槃.

Add a new option to choose whether to build tests or not.
@mlpack-bot

This comment has been minimized.

Copy link

mlpack-bot bot commented Nov 9, 2019

Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:

  • All code should follow the style guide
  • Documentation added for any new functionality
  • Tests added for any new functionality
  • Tests that are added follow the testing guide
  • Headers and license information added to the top of any new code files
  • HISTORY.md updated if the changes are big or user-facing
  • All CI checks should be passing

Thank you again for your contributions! 馃憤

@rcurtin
rcurtin approved these changes Nov 9, 2019
Copy link
Member

rcurtin left a comment

Awesome, thanks for fixing that documentation discrepancy. :)

Do you want to also add a note to HISTORY.md? If not I can handle it during merge. 馃憤

@rcurtin rcurtin removed the s: unanswered label Nov 9, 2019
@robertohueso

This comment has been minimized.

Copy link
Member Author

robertohueso commented Nov 9, 2019

History updated :) I forgot it 馃槄.

@zoq
zoq approved these changes Nov 10, 2019
Copy link
Member

zoq left a comment

Looks good to me.

@mlpack-bot

This comment has been minimized.

Copy link

mlpack-bot bot commented Nov 10, 2019

Hello there! Thanks for your contribution. I see that this is your first contribution to mlpack. If you'd like to add your name to the list of contributors in src/mlpack/core.hpp and COPYRIGHT.txt and you haven't already, please feel free to push a change to this PR---or, if it gets merged before you can, feel free to open another PR.

In addition, if you'd like some stickers to put on your laptop, I'd be happy to help get them in the mail for you. Just send an email with your physical mailing address to stickers@mlpack.org, and then one of the mlpack maintainers will put some stickers in an envelope for you. It may take a few weeks to get them, depending on your location. 馃憤

@zoq zoq merged commit 91e5abb into mlpack:master Nov 10, 2019
2 checks passed
2 checks passed
Static Code Analysis Checks Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zoq zoq removed the s: needs review label Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.