Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookahead - Synchronization period type fix #153

Merged
merged 3 commits into from Dec 28, 2019
Merged

Conversation

@zoq
Copy link
Member

zoq commented Dec 26, 2019

The builds fails (gcc 9.2.1), if the return type is wrong.

@zoq

This comment has been minimized.

Copy link
Member Author

zoq commented Dec 26, 2019

Once this is merged, we should make another release.

Copy link
Member

rcurtin left a comment

Ah, oops, I guess we missed it during review. :) Do you want to add a changelog entry to HISTORY.md? I can also do it during release, of course.

zoq added 2 commits Dec 27, 2019
@mlpack-bot
mlpack-bot bot approved these changes Dec 28, 2019
Copy link

mlpack-bot bot left a comment

Second approval provided automatically after 24 hours. 👍

@rcurtin

This comment has been minimized.

Copy link
Member

rcurtin commented Dec 28, 2019

I'll make another release once #154 is merged. (should be tomorrow morning I guess) 👍

@rcurtin rcurtin merged commit 839b94d into mlpack:master Dec 28, 2019
3 checks passed
3 checks passed
Static Code Analysis Checks Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mlpack master build test Build finished.
Details
@zoq

This comment has been minimized.

Copy link
Member Author

zoq commented Dec 28, 2019

Sounds good.

@zoq zoq removed the s: needs review label Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.