Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent spurious compiler warnings #161

Merged
merged 1 commit into from Jan 16, 2020
Merged

Conversation

@conradsnicta
Copy link
Contributor

conradsnicta commented Jan 15, 2020

prevent spurious compiler warnings as experienced when compiling mlpack-master with gcc 7.4 on ubuntu 18.04

this makes more important compiler warnings + errors more visible during the compilation process

conrad
@zoq

This comment has been minimized.

Copy link
Member

zoq commented Jan 15, 2020

Nice, saw the same issue on other configurations as well (https://dev.azure.com/mlpack/mlpack/_build/results?buildId=277&view=results).

@zoq
zoq approved these changes Jan 15, 2020
Copy link
Member

zoq left a comment

Ridiculous that we have to fix this, as this is clearly a compiler issue.

Copy link
Member

rcurtin left a comment

Awesome, really nice to have this fixed. I agree with @zoq that it's a bit ridiculous that we have to do this though. :)

@conradsnicta conradsnicta merged commit 5469374 into mlpack:master Jan 16, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Static Code Analysis Checks Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.