Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake package export. #198

Merged
merged 1 commit into from May 6, 2020
Merged

Fix cmake package export. #198

merged 1 commit into from May 6, 2020

Conversation

@Lasall
Copy link
Contributor

@Lasall Lasall commented May 4, 2020

Just some minor fixes for cmake package export:

  • Fix spelling mistake introduced in 369046f
  • Don't export compiler warning flags to interface.
@mlpack-bot
Copy link

@mlpack-bot mlpack-bot bot commented May 4, 2020

Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:

  • All code should follow the style guide
  • Documentation added for any new functionality
  • Tests added for any new functionality
  • Tests that are added follow the testing guide
  • Headers and license information added to the top of any new code files
  • HISTORY.md updated if the changes are big or user-facing
  • All CI checks should be passing

Thank you again for your contributions! 👍

@birm birm self-requested a review May 4, 2020
@birm
birm approved these changes May 4, 2020
Copy link
Member

@birm birm left a comment

Looks good; thanks for the fix/improvement! You may want to update HISTORY.md with this fix though.

@mlpack-bot
mlpack-bot bot approved these changes May 5, 2020
Copy link

@mlpack-bot mlpack-bot bot left a comment

Second approval provided automatically after 24 hours. 👍

@mlpack-bot
Copy link

@mlpack-bot mlpack-bot bot commented May 5, 2020

Hello there! Thanks for your contribution. I see that this is your first contribution to mlpack. If you'd like to add your name to the list of contributors in src/mlpack/core.hpp and COPYRIGHT.txt and you haven't already, please feel free to push a change to this PR---or, if it gets merged before you can, feel free to open another PR.

In addition, if you'd like some stickers to put on your laptop, I'd be happy to help get them in the mail for you. Just send an email with your physical mailing address to stickers@mlpack.org, and then one of the mlpack maintainers will put some stickers in an envelope for you. It may take a few weeks to get them, depending on your location. 👍

@mlpack-bot mlpack-bot bot removed the s: needs review label May 5, 2020
@zoq
Copy link
Member

@zoq zoq commented May 5, 2020

@Lasall thanks for putting this together, can you update https://github.com/mlpack/ensmallen/blob/master/HISTORY.md, to reflect the change, the rest looks good to me.

@Lasall Lasall force-pushed the Lasall:cmake-export-fix branch from 7c9a025 to b05d9fa May 6, 2020
* Fix spelling mistake introduced in 369046f

* Don't export compiler warning flags to interface.
@Lasall Lasall force-pushed the Lasall:cmake-export-fix branch from b05d9fa to 1aa9e2e May 6, 2020
@zoq
zoq approved these changes May 6, 2020
Copy link
Member

@zoq zoq left a comment

Thanks, looks good to me.

@birm birm merged commit 70a2be8 into mlpack:master May 6, 2020
3 of 4 checks passed
3 of 4 checks passed
Memory Checks Build finished.
Details
Static Code Analysis Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.