Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix cmake package export. #198
Conversation
|
Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:
Thank you again for your contributions! |
|
Looks good; thanks for the fix/improvement! You may want to update HISTORY.md with this fix though. |
|
Second approval provided automatically after 24 hours. |
|
Hello there! Thanks for your contribution. I see that this is your first contribution to mlpack. If you'd like to add your name to the list of contributors in In addition, if you'd like some stickers to put on your laptop, I'd be happy to help get them in the mail for you. Just send an email with your physical mailing address to stickers@mlpack.org, and then one of the mlpack maintainers will put some stickers in an envelope for you. It may take a few weeks to get them, depending on your location. |
|
@Lasall thanks for putting this together, can you update https://github.com/mlpack/ensmallen/blob/master/HISTORY.md, to reflect the change, the rest looks good to me. |
* Fix spelling mistake introduced in 369046f * Don't export compiler warning flags to interface.
|
Thanks, looks good to me. |
Just some minor fixes for cmake package export: