Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix release script #216
Merged
Fix release script #216
Conversation
|
I will update |
|
Alright, now I will rebase on top of the current upstream master and then update HISTORY.md accordingly. |
|
Thanks for looking into this! I think I might have found a bug in the awk program---let me know what you think. |
Co-authored-by: Ryan Curtin <ryan@ratml.org>
|
Thanks, looks good to me! |
|
Looks good to me. |
| @@ -23,7 +23,8 @@ if [ "$#" -gt 5 ]; then | |||
| fi | |||
|
|
|||
| # Make sure that the branch is clean. | |||
| lines=`git diff | wc -l`; | |||
| # Truncate leading whitespaces since wc -l on MacOS adds an extra \t. | |||
zoq
Aug 12, 2020
Member
I think it's macOS but don't think people will be confused.
I think it's macOS but don't think people will be confused.
coatless
Aug 16, 2020
Contributor
It's macOS... No one will be confused. just don't name it OS X 😉
It's macOS... No one will be confused. just don't name it OS X
rcurtin
Aug 16, 2020
Member
Is it a roman numeral or not? Do I pronounce it X or 10? Question for the ages 😄
Is it a roman numeral or not? Do I pronounce it X or 10? Question for the ages
|
Looks promising! |
|
Thanks @say4n! |
This was referenced Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fix release script to use CLI arguments instead of the hardcoded ones.