Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quotation bug in release script. #220

Merged
merged 2 commits into from Aug 19, 2020
Merged

Conversation

@rcurtin
Copy link
Member

@rcurtin rcurtin commented Aug 18, 2020

This is a simple change to correctly extract the changelog in the release script. Previously, it would search for, e.g.,

### ensmallen 2.14.1: No Direction Home

but it needs to search for

### ensmallen 2.14.1: "No Direction Home"

You can see an example of the existing script failing in #218 and then the modified script succeeding in #219.

@birm
birm approved these changes Aug 18, 2020
@zoq
zoq approved these changes Aug 19, 2020
Copy link
Member

@zoq zoq left a comment

Makes sense, looks good to me.

@mlpack-bot mlpack-bot bot removed the s: needs review label Aug 19, 2020
@zoq zoq merged commit 0431e31 into mlpack:master Aug 19, 2020
5 checks passed
5 checks passed
Memory Checks Build finished.
Details
Static Code Analysis Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mlpack master build test Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.