Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old documentation #61

Merged
merged 5 commits into from Dec 9, 2018

Conversation

@rcurtin
Copy link
Member

commented Dec 5, 2018

This removes all the extra documentation that describes FunctionType for each optimizer. Instead now I changed it to reference the documentation in function_types.md, which is more likely to be up to date.

Also I moved a few files relating to the FrankWolfe optimizer into the fw/ directory.

@zoq

zoq approved these changes Dec 9, 2018

Copy link
Member

left a comment

This looks good to me, I guess we should update the PR one more time to addresse the merged Padam optimizer.

@rcurtin rcurtin merged commit 86b41f8 into mlpack:master Dec 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rcurtin rcurtin deleted the rcurtin:doc-cleanup branch Dec 9, 2018

@rcurtin

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2018

I'm not in a hurry, so I think it's fine to wait until #61 is ready until releasing 1.12.0 with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.