Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline to end of files to quiet line ending warning. #65

Merged
merged 1 commit into from Jan 3, 2019

Conversation

@coatless
Copy link
Contributor

commented Jan 3, 2019

This is a minor PR that adds new lines to the end of two header files that lack them. These header files were being picked up during a nightly R CMD check run on the R package (note: new patch deployed for 1.12 and, so, the link may no longer be relevant.)

c.f. https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/RcppEnsmallen-00check.html

checking line endings in C/C++/Fortran sources/headers ... NOTE
Found the following sources/headers not terminated with a newline:
....
Some compilers warn on such files.
@zoq
zoq approved these changes Jan 3, 2019
Copy link
Member

left a comment

This looks good to me 👍 I'll go ahead and merge this in 2 days, to leave time for any other comments.

@rcurtin
rcurtin approved these changes Jan 3, 2019
Copy link
Member

left a comment

👍 Thanks! Feel free to always open PRs to fix little stuff like this, it is very easy to review and merge.

I'll go ahead and merge it now and release a new version, since I have a nice script that makes that easy now. :)

@rcurtin rcurtin merged commit f370ede into mlpack:master Jan 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@coatless

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2019

Thanks folks!

@rcurtin mind sharing the release script?

@rcurtin

This comment has been minimized.

Copy link
Member

commented Jan 4, 2019

Sure, actually I put it in the ensmallen.org repository:
https://github.com/mlpack/ensmallen.org/blob/master/scripts/release-ensmallen.sh

Since the mlpack release process is so tedious, I worked to make the ensmallen process the opposite of that. I'd like to move the mlpack process to something that looks more like this... but there is a long way to go before that. :)

@coatless

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2019

@rcurtin thank you! That's a very useful script. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.