Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline to end of `de.hpp` file #92

Merged
merged 1 commit into from Mar 10, 2019

Conversation

@coatless
Copy link
Contributor

commented Mar 10, 2019

Added a newline to the end of de.hpp to quiet a CRAN warning.

Found the following sources/headers not terminated with a newline:
inst/include/ensmallen_bits/de/de.hpp

@coatless coatless referenced this pull request Mar 10, 2019

Merged

Upgrade to ensmallen 1.14.1 #9

@rcurtin
Copy link
Member

left a comment

Oops, sorry about that. Does it make your life easier if I release 1.14.2 with this change? If so I will do it, just let me know. :)

@coatless

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

@rcurtin nope. We've already shipped the slight change with 1.14.1

I'll likely poke around the testing infrastructure to insert the common compile flags being used on CRAN to catch this issue, which is a non-issue since C++11....

@rcurtin

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

Ok. I'll merge this now then, but won't do a release. If you have other changes that make your life easier, I'm all for them too. 👍

@rcurtin rcurtin merged commit c6c9ec0 into mlpack:master Mar 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zoq zoq referenced this pull request Mar 11, 2019

Merged

`cyclical_decay.hpp` BibTeX fix #95

rcurtin added a commit to rcurtin/ensmallen that referenced this pull request Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.