New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value of a PARAM_INT_OUT is not printed #1100

Closed
alexandretea opened this Issue Aug 23, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@alexandretea

alexandretea commented Aug 23, 2017

When an output parameter is defined using the macro PARAM_INT_OUT, the parameter is not printed even if a value has been set to it. I'm using the version 2.2.4 of mlpack.

The following code shows the problem:

#include <mlpack/core.hpp>

using namespace mlpack;

PARAM_DOUBLE_OUT("out_double", "desc");
PARAM_INT_OUT("out_int", "desc");

int main(int argc, char** argv)
{
    CLI::GetParam<double>("out_double") = 42.8484;
    CLI::GetParam<int>("out_int") = 13;
    return 0;
}

Running this code, only the double output parameter is printed.

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Aug 25, 2017

Member

Thanks for pointing this out. I am about to release a bugfix 2.2.5, I'll include a fix for this also.

Member

rcurtin commented Aug 25, 2017

Thanks for pointing this out. I am about to release a bugfix 2.2.5, I'll include a fix for this also.

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Aug 26, 2017

Member

Thanks so much for the simple code to test the fix, it really is nice to get a simple program like that for debugging. :)

It turns out, the problem was quite simple: f77fe95. I released mlpack-2.2.5 with the fix: http://www.mlpack.org/files/mlpack-2.2.5.tar.gz.

Please feel free to report any issues in the future, and we'll be happy to try and fix them. :)

Member

rcurtin commented Aug 26, 2017

Thanks so much for the simple code to test the fix, it really is nice to get a simple program like that for debugging. :)

It turns out, the problem was quite simple: f77fe95. I released mlpack-2.2.5 with the fix: http://www.mlpack.org/files/mlpack-2.2.5.tar.gz.

Please feel free to report any issues in the future, and we'll be happy to try and fix them. :)

@rcurtin rcurtin closed this Aug 26, 2017

@rcurtin rcurtin added the R: fixed label Aug 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment