New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'svd': illegal use of namespace identifier in expression #1443

Closed
kilasuelika opened this Issue Jun 23, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@kilasuelika

kilasuelika commented Jun 23, 2018

When build mlpack using Windows, an error occured:

Severity Code Description Project File Line Suppression State
Error C2882 'svd': illegal use of namespace identifier in expression (compiling source file G:\Coding\C++\mlpack-master\src\mlpack\Release\cotire\mlpack_CXX_unity_54_62.cxx) mlpack_unity g:\coding\c++\mlpack-master\src\mlpack\methods\radical\radical.cpp 190

The file contains error is mlpack\methods\radical\radical.cpp.

@kilasuelika

This comment has been minimized.

Show comment
Hide comment
@kilasuelika

kilasuelika Jun 23, 2018

I modify the 190 line of source file to:
arma::svd(matU, s, matV, cov(matX));

And build successfully.

kilasuelika commented Jun 23, 2018

I modify the 190 line of source file to:
arma::svd(matU, s, matV, cov(matX));

And build successfully.

@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq Jun 23, 2018

Member

Good point, do you like to open a PR with the modification, don't feel obligated, just wanted to ask first.

Member

zoq commented Jun 23, 2018

Good point, do you like to open a PR with the modification, don't feel obligated, just wanted to ask first.

@zoq zoq reopened this Jun 23, 2018

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Jun 27, 2018

Member

Thanks for pointing this out, it's such a simple change that I went ahead and made a PR (#1451).

Member

rcurtin commented Jun 27, 2018

Thanks for pointing this out, it's such a simple change that I went ahead and made a PR (#1451).

@rcurtin rcurtin added the T: defect label Jun 27, 2018

@rcurtin rcurtin closed this in a2c7909 Jun 28, 2018

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Jun 28, 2018

Member

Ok, #1451 is merged so this is closed now. Thanks again for pointing out the issue, and don't hesitate to post any more problems if you have them. :)

Member

rcurtin commented Jun 28, 2018

Ok, #1451 is merged so this is closed now. Thanks again for pointing out the issue, and don't hesitate to post any more problems if you have them. :)

@rcurtin rcurtin added the R: fixed label Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment