Don't use `const char*` anywhere #177

Closed
rcurtin opened this Issue Dec 29, 2014 · 3 comments

Projects

None yet

1 participant

@rcurtin
Member
rcurtin commented Dec 29, 2014

Reported by rcurtin on 8 Feb 42036575 02:29 UTC
Use std::string (or a reference to a string) instead. This is for consistency's sake. I think the main culprit is CLI, which does this all over the place.

@rcurtin rcurtin self-assigned this Dec 29, 2014
@rcurtin rcurtin added this to the mlpack 1.0.1 milestone Dec 29, 2014
@rcurtin rcurtin closed this Dec 29, 2014
@rcurtin
Member
rcurtin commented Dec 30, 2014

Commented by jcline3 on 29 Aug 42124292 10:37 UTC
Just an update to this, grep -r "const char" * in src/mlpack/methods returns nothing.

There seems to be 60 occurrences of it in core, however, about 12 of which are in arma_extend. All the rest are in util.

@rcurtin
Member
rcurtin commented Dec 30, 2014

Commented by rcurtin on 15 Jul 42159736 19:04 UTC
No need to worry about anything in arma_extend. Dragons live there.

@rcurtin
Member
rcurtin commented Dec 30, 2014

Commented by rcurtin on 16 Nov 42171203 16:14 UTC
Done with r11709.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment