GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reported by rcurtin on 8 Feb 42036575 02:29 UTC
Use std::string (or a reference to a string) instead. This is for consistency's sake. I think the main culprit is CLI, which does this all over the place.
Commented by jcline3 on 29 Aug 42124292 10:37 UTC
Just an update to this, grep -r "const char" * in src/mlpack/methods returns nothing.
grep -r "const char" *
There seems to be 60 occurrences of it in core, however, about 12 of which are in arma_extend. All the rest are in util.
Commented by rcurtin on 15 Jul 42159736 19:04 UTC
No need to worry about anything in arma_extend. Dragons live there.
Commented by rcurtin on 16 Nov 42171203 16:14 UTC
Done with r11709.