New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allknn and allkfn output results in tree-order #204

Closed
rcurtin opened this Issue Dec 29, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@rcurtin
Member

rcurtin commented Dec 29, 2014

Reported by rriegel on 23 Feb 42201264 03:09 UTC
While code is in place to restore result order and found neighbor indices to the input files' original order, the final data::Save calls still reference the uncorrected result matrices.

data::Save should be called on the corrected distancesOut and neighborsOut, rather than just distances and neighbors.

@rcurtin rcurtin self-assigned this Dec 29, 2014

@rcurtin rcurtin added this to the mlpack 1.0.2 milestone Dec 29, 2014

@rcurtin rcurtin closed this Dec 29, 2014

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Dec 30, 2014

Member

Commented by rcurtin on 22 Aug 42201688 08:52 UTC
Wow, there's an error that makes me feel http://tinyurl.com/88j3jcd . Fixed in r11853. Thanks for pointing it out...

Member

rcurtin commented Dec 30, 2014

Commented by rcurtin on 22 Aug 42201688 08:52 UTC
Wow, there's an error that makes me feel http://tinyurl.com/88j3jcd . Fixed in r11853. Thanks for pointing it out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment