New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHrectBound -> DHRectBound and DHRectPeriodicBound #58

Closed
rcurtin opened this Issue Dec 29, 2014 · 2 comments

Comments

Projects
None yet
1 participant
@rcurtin
Member

rcurtin commented Dec 29, 2014

Reported by rcurtin on 15 Feb 40361195 09:46 UTC
The DHRectBound class provides many useful functions, like MinDistance() and MaxDistance(), but it also provides a MinPeriodicDistance() and MaxPeriodicDistance() function. A better design would be to split this into two classes, where in the DHRectPeriodicBound class, MaxDistance() and MinDistance() are supplied but are the periodic equivalents of DHRectBound. Therefore DHRectPeriodicBound will also need to store a box_size member.

This will allow DHRectBound and DHRectPeriodicBound to be swapped easily, whereas before you had to specify the individual function members.

@rcurtin rcurtin self-assigned this Dec 29, 2014

@rcurtin rcurtin closed this Dec 29, 2014

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Dec 29, 2014

Member

Commented by rcurtin on 4 Dec 41961381 13:13 UTC
Working code did not appear for 1.0 release; had to be dropped.

Member

rcurtin commented Dec 29, 2014

Commented by rcurtin on 4 Dec 41961381 13:13 UTC
Working code did not appear for 1.0 release; had to be dropped.

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Dec 29, 2014

Member

Commented by rcurtin on 11 Jul 44114117 08:25 UTC
This was never finished, never worked, and nobody uses it (to my knowledge) so I have removed PeriodicHRectBound entirely in r16266-r16268 and am closing this bug wontfix.

Member

rcurtin commented Dec 29, 2014

Commented by rcurtin on 11 Jul 44114117 08:25 UTC
This was never finished, never worked, and nobody uses it (to my knowledge) so I have removed PeriodicHRectBound entirely in r16266-r16268 and am closing this bug wontfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment