bug in HMM #600

Closed
warpuv opened this Issue Apr 1, 2016 · 4 comments

Projects

None yet

2 participants

@warpuv
warpuv commented Apr 1, 2016

In file mlpack\methods\hmm\hmm_impl.hpp, line 169:

    if (dataSeq.size() == 0)
      initial = newInitial / dataSeq.size();

Should be probably dataSeq.size() > 1.
mlpack version 2.0.1

@rcurtin
Member
rcurtin commented Apr 5, 2016

There's something deeper that's wrong here, but I need to find my copy of the Elliot, Aggoun, and Moore book to figure out exactly what's up. So this may take a few days (since I'm out of town). Thanks for pointing the issue out!

@rcurtin rcurtin added this to the mlpack 2.0.2 milestone Apr 5, 2016
@rcurtin rcurtin self-assigned this Apr 5, 2016
@rcurtin
Member
rcurtin commented Apr 12, 2016

d6d38a1 should fix the issue. There was also an issue with how the newInitial matrix was being set. Thanks for reporting the problem!

@rcurtin rcurtin closed this Apr 12, 2016
@warpuv
warpuv commented Apr 12, 2016

You forgot to add else condition. initial is not changing if number of sequences equal to one. Thanks for fixing.

@rcurtin
Member
rcurtin commented Apr 13, 2016

Good catch, thanks for checking my work. e0e7ba5 should fix this.

@rcurtin rcurtin added the R: fixed label Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment