New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in gaussian init #1000

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
3 participants
@ShangtongZhang
Member

ShangtongZhang commented May 17, 2017

Please find more discussions about this here.
Briefly speaking, it seems the init function goes wrong when the desired mat has pre-allocated memory. But I don't know why.

@zoq zoq merged commit d463c36 into mlpack:master May 18, 2017

3 checks passed

Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq May 18, 2017

Member

Nice catch and thanks for the patch.

Member

zoq commented May 18, 2017

Nice catch and thanks for the patch.

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin May 18, 2017

Member

Here's a trophy for getting issue #1000!

:)

Member

rcurtin commented May 18, 2017

Here's a trophy for getting issue #1000!

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment