New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method form detection tool #1020

Merged
merged 14 commits into from Jun 13, 2017

Conversation

Projects
None yet
2 participants
@micyril
Member

micyril commented Jun 6, 2017

Add a tool that allows to check at compile time whether a given class
has a method of the requested form with the specified number of
additional arguments. See #929 for additional comments.

micyril added some commits Jun 5, 2017

Add a method form detection tool
Add a tool that allows to check at compile time whether a given class
has a method of the requested form with the specified number of
additional arguments.
@micyril

This comment has been minimized.

Show comment
Hide comment
@micyril

micyril Jun 7, 2017

Member

It looks like some tests randomly fail since my last commit just adds a description of the test.

Member

micyril commented Jun 7, 2017

It looks like some tests randomly fail since my last commit just adds a description of the test.

@rcurtin

rcurtin approved these changes Jun 8, 2017

Looks great to me. I see that the number of arguments we can accept is limited, but I don't think that's a huge problem, and I don't see an easy way around it.

Show outdated Hide outdated src/mlpack/core/util/sfinae_utility.hpp
@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Jun 8, 2017

Member

I should add, the Radical test failure has nothing to do with your code, so I am not worried about it. See #922 for more information.

Member

rcurtin commented Jun 8, 2017

I should add, the Radical test failure has nothing to do with your code, so I am not worried about it. See #922 for more information.

@micyril

This comment has been minimized.

Show comment
Hide comment
@micyril

micyril Jun 9, 2017

Member

I want to add some more related code here, so to review it all at once.

Member

micyril commented Jun 9, 2017

I want to add some more related code here, so to review it all at once.

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Jun 9, 2017

Member

Ok, sure, I will not merge it until you let me know that it is ready then, and I will review more as you add it.

Member

rcurtin commented Jun 9, 2017

Ok, sure, I will not merge it until you let me know that it is ready then, and I will review more as you add it.

@micyril

This comment has been minimized.

Show comment
Hide comment
@micyril

micyril Jun 9, 2017

Member

I think it's ready for reviewing now.

Member

micyril commented Jun 9, 2017

I think it's ready for reviewing now.

@rcurtin

Looks great, I don't see anything wrong other than the comment I made about Boost tests. Is this ready for merge otherwise?

Show outdated Hide outdated src/mlpack/tests/sfinae_test.cpp
@micyril

This comment has been minimized.

Show comment
Hide comment
@micyril

micyril Jun 13, 2017

Member

Yes, it's ready if there are no more questions.

Member

micyril commented Jun 13, 2017

Yes, it's ready if there are no more questions.

@rcurtin rcurtin merged commit 8b17c66 into mlpack:master Jun 13, 2017

3 checks passed

Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment