New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregated policy for async rl methods #1056

Merged
merged 5 commits into from Jul 19, 2017

Conversation

Projects
None yet
3 participants
@ShangtongZhang
Member

ShangtongZhang commented Jul 13, 2017

No description provided.

@zoq

zoq approved these changes Jul 14, 2017

Looks good to me; we should let this sit for 3 before the merge to give anyone else time to comment.

@ShangtongZhang

This comment has been minimized.

Show comment
Hide comment
@ShangtongZhang

ShangtongZhang Jul 14, 2017

Member

@zoq Can you trigger the test process for #934? As arma is now updated, I want to see whether it works or not.

Member

ShangtongZhang commented Jul 14, 2017

@zoq Can you trigger the test process for #934? As arma is now updated, I want to see whether it works or not.

@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq Jul 14, 2017

Member

@ShangtongZhang I think the latest commit already triggered the build: https://travis-ci.org/mlpack/mlpack/builds/253458551?utm_source=github_status&utm_medium=notification but it looks like it timed out.

Member

zoq commented Jul 14, 2017

@ShangtongZhang I think the latest commit already triggered the build: https://travis-ci.org/mlpack/mlpack/builds/253458551?utm_source=github_status&utm_medium=notification but it looks like it timed out.

@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq Jul 14, 2017

Member

@ShangtongZhang Anyway, I can restart the build if you like.

Member

zoq commented Jul 14, 2017

@ShangtongZhang Anyway, I can restart the build if you like.

@ShangtongZhang

This comment has been minimized.

Show comment
Hide comment
@ShangtongZhang

ShangtongZhang Jul 14, 2017

Member

@zoq Sure. Thanks!

Member

ShangtongZhang commented Jul 14, 2017

@zoq Sure. Thanks!

ShangtongZhang added some commits Jul 15, 2017

@ShangtongZhang

This comment has been minimized.

Show comment
Hide comment
@ShangtongZhang

ShangtongZhang Jul 19, 2017

Member

Could anyone merge this PR?

Member

ShangtongZhang commented Jul 19, 2017

Could anyone merge this PR?

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Jul 19, 2017

Member

Sure, I can hit the button. :)

Member

rcurtin commented Jul 19, 2017

Sure, I can hit the button. :)

@rcurtin rcurtin merged commit 923df37 into mlpack:master Jul 19, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Style Checks Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment