Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add a hyper-parameter tuning module #1101
Also, I have noticed that the style checks haven't been run for my last submission. Is it expected behavior?
Looks great to me. Thanks again for the hard work. Let's wait for 5 days before merge, just to make sure everyone who wants to comment has a chance.
DatasetMapper changes look fine to me; sorry that the
bimap change caused trouble for you at merge. I think that maybe someday it might be worthwhile to refactor so that
InputType is a function template parameter to the mapping functions, instead of a class template parameter, but I don't think that needs to happen today, that can be later.
Thanks for letting this sit for a couple days. The code is really well written; just made a minor comment about the default HyperParameterTuner parameter.