New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorials for the cross-validation and hyper-parameter tuning modules #1108

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@micyril
Member

micyril commented Aug 31, 2017

No description provided.

@rcurtin

rcurtin approved these changes Sep 8, 2017

Sorry for the slow review---I had to handle some other things this week. I think this looks good, but I wanted to ask if you were ok if I added some details on what cross-validation and hyper-parameter tuning are after merge. I think it would also be nice to split into two tutorials, one for cross-validation and one for hyper-parameter tuning. Let me know what you think.

@micyril

This comment has been minimized.

Show comment
Hide comment
@micyril

micyril Sep 9, 2017

Member

I think this looks good, but I wanted to ask if you were ok if I added some details on what cross-validation and hyper-parameter tuning are after merge.

If you are asking for my permission for editing these tutorials after this PR is merged, my answer is yes, and you didn't even need to ask about it.

Member

micyril commented Sep 9, 2017

I think this looks good, but I wanted to ask if you were ok if I added some details on what cross-validation and hyper-parameter tuning are after merge.

If you are asking for my permission for editing these tutorials after this PR is merged, my answer is yes, and you didn't even need to ask about it.

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Sep 18, 2017

Member

Oops, this one fell off my radar---I had everything ready to go last week but forgot to actually do the merge. I merged this with some changes, but it looks like Github is not picking up the merge commit correctly or I did it wrong. Anyway, the tutorials are merged with some changes in 8e58465. Thanks again for writing the tutorials and let me know if you see any problems with the changes I made.

Member

rcurtin commented Sep 18, 2017

Oops, this one fell off my radar---I had everything ready to go last week but forgot to actually do the merge. I merged this with some changes, but it looks like Github is not picking up the merge commit correctly or I did it wrong. Anyway, the tutorials are merged with some changes in 8e58465. Thanks again for writing the tutorials and let me know if you see any problems with the changes I made.

@rcurtin rcurtin closed this Sep 18, 2017

@micyril

This comment has been minimized.

Show comment
Hide comment
@micyril

micyril Sep 19, 2017

Member

I think the changes you have made are very good - they make the tutorials much more comprehensive. I left some minor comments in the places where I think we can be a bit more precise.

Member

micyril commented Sep 19, 2017

I think the changes you have made are very good - they make the tutorials much more comprehensive. I left some minor comments in the places where I think we can be a bit more precise.

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Sep 25, 2017

Member

Thanks, I appreciate the comments. I handled all of them (except one I responded to on Github) in a6065e4.

Member

rcurtin commented Sep 25, 2017

Thanks, I appreciate the comments. I handled all of them (except one I responded to on Github) in a6065e4.

@micyril micyril changed the title from Add a tutorial for the cross-validation and hyper-parameter tuning modules to Add tutorials for the cross-validation and hyper-parameter tuning modules Jun 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment