Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Single output for multiple timestep input for RNN #1348
Thanks for the contribution. I think the changes are pretty simple and I'm happy to see it was this easy. I do think we should be sure to clarify the documentation, so if you are able to do that it would be great.
I have just a few comments about the code itself; let me know if I can clarify any of them. In any case we should definitely also wait on Marcus's input here before merging, since he may have been envisioning a different solution (I am not sure).
I also noticed something strange. When I run my test in isolation the mean error I get is lot less. But when I run my test with the other test, it seems to generate error which is much higher. Please see below:
Is there a reason that the test should be affected by other tests?
Sorry I should have mentioned. This is happening consistently. Not one off. Also the order of the mean error is 1e-5 when run in isolation. And it is 1e-02 when run with other tests.…
On Tue, Apr 3, 2018, 22:16 Ryan Curtin ***@***.***> wrote: Right, I think Manthan is correct here. It would probably be good to run the test many times with different random seeds and ensure that it does not fail. You may have to adjust the tolerance of the test. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1348 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AhKoKqvl1KNjBFQdWVY_RKBjpP_sT3Afks5tk6dRgaJpZM4TCfjr> .
Apr 20, 2018
Thank you for the review and merge. Happy to add my two cents....…
On Fri, Apr 20, 2018, 23:07 Marcus Edel ***@***.***> wrote: Thanks again for a great contribution. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1348 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AhKoKotxa95EzQK9NcmEoprcWzdvVoHMks5tqhzdgaJpZM4TCfjr> .