New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unused result warning #1373

Merged
merged 1 commit into from Apr 20, 2018

Conversation

Projects
None yet
3 participants
@conradsnicta
Contributor

conradsnicta commented Apr 19, 2018

Recent versions of armadillo emit warnings when the result of iterator postfix increment/decrement is not used. The void statement by itself isn't sufficient to suppress these warnings.

@zoq

zoq approved these changes Apr 19, 2018

No comments from my side, thanks! I'll go ahead and merge this in 3 days to leave time for any other comments.

@conradsnicta

This comment has been minimized.

Contributor

conradsnicta commented Apr 19, 2018

The change is also directly applicable to the mlpack-3.x branch. Should I open a separate pull request for that, or just leave it for backporting later?

@zoq

This comment has been minimized.

Member

zoq commented Apr 20, 2018

Your choice, either way, is fine with me.

@rcurtin

Looks good to me, thanks for the fix. An easy review. :)

@zoq zoq merged commit 2cd7386 into mlpack:master Apr 20, 2018

5 checks passed

Memory Checks
Details
Static Code Analysis Checks Build finished.
Details
Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zoq

This comment has been minimized.

Member

zoq commented Apr 20, 2018

Thanks again, for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment