Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update NeighborSearch: Switching l-rvalue reference overload to pass-by-value #1378
Switching lvalue reference and rvalue reference overload to pass-by-value argument in the Neighbor Search algorithm, as suggested at #1021 issue.
A user can pass the data by making a copy (Method(data)) or, avoiding copies if possible, by moving the data into the method (Method(std::move(data))).
Hey there, thanks! This looks great. I don't see any issues with it at all. I will go ahead and merge it in 3 days, to leave time for other comments.
If you'd like to add your name to the list of contributors in
COPYRIGHT.txt, please feel free. Also, if you like, I can mail you mlpack stickers that you can put on your laptop. If you'd like some, just send me an email with your mailing address to email@example.com.
Thanks again for the nice contribution!