New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NeighborSearch: Switching l-rvalue reference overload to pass-by-value #1378

Merged
merged 4 commits into from Apr 30, 2018

Conversation

Projects
None yet
2 participants
@ThanasisMattas
Contributor

ThanasisMattas commented Apr 21, 2018

Switching lvalue reference and rvalue reference overload to pass-by-value argument in the Neighbor Search algorithm, as suggested at #1021 issue.

A user can pass the data by making a copy (Method(data)) or, avoiding copies if possible, by moving the data into the method (Method(std::move(data))).

@rcurtin

Hey there, thanks! This looks great. I don't see any issues with it at all. I will go ahead and merge it in 3 days, to leave time for other comments.

If you'd like to add your name to the list of contributors in src/mlpack/core.hpp and COPYRIGHT.txt, please feel free. Also, if you like, I can mail you mlpack stickers that you can put on your laptop. If you'd like some, just send me an email with your mailing address to ryan@ratml.org.

Thanks again for the nice contribution!

ThanasisMattas added some commits Apr 26, 2018

@rcurtin rcurtin merged commit f705696 into mlpack:master Apr 30, 2018

4 of 5 checks passed

Static Code Analysis Checks Build finished.
Details
Memory Checks
Details
Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rcurtin

This comment has been minimized.

Member

rcurtin commented Apr 30, 2018

Thanks again! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment