Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add missing check to suppress compiler warning #1380
Thanks so much for the fix here. I think that it is not possible for the code to actually get to that point. So an easier fix would be to change the last
else if to just an
else. If you'd like to make that change, feel free, otherwise I will switch the code when I do the merge.
I'll go ahead and merge this in 3 days to leave time for comments. If you like, we can add your name to the list of contributors in
COPYRIGHT.txt (since even though it is a small contribution it is still a contribution!). Also, if you like, I can mail you some mlpack stickers that you can put on your laptop. If you want some, send me your mailing address at email@example.com and I will put them in the mail.
Thanks for clarifying, I didn't know it because I just start to get myself familiar with machine learning and mlpack, so this is just a minor patch without knowing the context. I just update it with a new commit.
That would be nice! Stickers will look cool. I think I can contribute more when I get familiar enough with ML and mlpack.
The new commit fails travis-ci test, saying
However, when I run
It looks strange since I never touch that test case or source file. I wonder are you having the same issue?