New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiplyMerge layer added #1392

Merged
merged 3 commits into from May 16, 2018

Conversation

Projects
None yet
3 participants
@haritha1313
Contributor

haritha1313 commented May 14, 2018

No description provided.

Show outdated Hide outdated src/mlpack/methods/ann/layer/multiply_merge.hpp
@@ -59,6 +59,8 @@ set(SOURCES
mean_pooling_impl.hpp
multiply_constant.hpp
multiply_constant_impl.hpp
multiply_merge.hpp

This comment has been minimized.

@zoq
@zoq

haritha1313 added some commits May 15, 2018

@zoq

zoq approved these changes May 15, 2018

Everything looks good to me, I'll go ahead and merge this in 3 days to leave time for any other comments.

@haritha1313

This comment has been minimized.

Show comment
Hide comment
@haritha1313

haritha1313 May 16, 2018

Contributor

@zoq Do you think the build failure is something random? I'm not able to find any noticeable error in the console output.

Contributor

haritha1313 commented May 16, 2018

@zoq Do you think the build failure is something random? I'm not able to find any noticeable error in the console output.

@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq May 16, 2018

Member

The build failure isn't related with the PR, I'll have to check the jenkins configuration, looks like something failed in the script build process. I'll restart the build once the issue is solved.

Member

zoq commented May 16, 2018

The build failure isn't related with the PR, I'll have to check the jenkins configuration, looks like something failed in the script build process. I'll restart the build once the issue is solved.

@rcurtin

No comments from my side; the code looks pretty straightforward and I don't see any issues. 👍

@zoq zoq merged commit d44d4cd into mlpack:master May 16, 2018

4 of 5 checks passed

Static Code Analysis Checks Build finished.
Details
Memory Checks
Details
Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq May 16, 2018

Member

Thanks again, easy merge.

Member

zoq commented May 16, 2018

Thanks again, easy merge.

@haritha1313 haritha1313 deleted the haritha1313:multmerge branch May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment