Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptation of SDP to incorporate inequality constraints. #1395

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@manish7294
Copy link
Member

manish7294 commented May 15, 2018

Included sparseInequalityA and denseInequalityA and have made required changes to LRSDP, primal-dual and matrix completion method.

manish7294 added some commits May 15, 2018

@manish7294

This comment has been minimized.

Copy link
Member Author

manish7294 commented May 16, 2018

@rcurtin I think it's ready for review now.

@rcurtin
Copy link
Member

rcurtin left a comment

Oops, looks like I did not submit the review here!

Do you think this is still necessary? If you want we can merge this, but given that we don't currently have a reason to use it, maybe it is better to avoid adding unused support. Let me know what you think---I could go either way.

@@ -105,7 +105,7 @@ class PrimalDualSolver
//! Starting lagrange multiplier for the sparse constraints.
arma::vec initialYsparse;

//! Starting lagrange multiplier for the sparse constraints.
//! Starting lagrange multiplier for the dense constraints.

This comment has been minimized.

@rcurtin

rcurtin May 23, 2018

Member

Nice catch, thank you. :)

This comment has been minimized.

@manish7294

manish7294 May 23, 2018

Author Member

:)

@manish7294

This comment has been minimized.

Copy link
Member Author

manish7294 commented May 23, 2018

Yeah! I agree with you. We can close this as of now, I think we can always open it if it will be needed in future by anyone :)

@rcurtin

This comment has been minimized.

Copy link
Member

rcurtin commented May 23, 2018

I grabbed the spelling fix in 949ab83, and I'll go ahead and close this then. 👍

@rcurtin rcurtin closed this May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.