Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
CF Interpolation Weights #1410
All neighbor search classes and weights interpolation classes are added. I might spend some time later to work on
I will templatize some functions in
Regarding your question at #mlpack:
@lozhnikov That's a good solution. Correct me if I'm misunderstand. Let's say we use
I have one more question about this solution. To refactor
Actually, looks good to me. I just pointed out some interesting points.
InterpolationPolicy away from the
CF class itself is really nice, since it allows users of a single
CF model to get predictions in numerous different ways without having to redo the decomposition.
I think in the long term it might be nice to make some of these different search options and interpolation options available in
cf_main.cpp, but I don't see it as a huge priority to do that immediately.
Overall it looks great! I am excited to see it merged.