New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigBatchSGD remove random seed #1440

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
3 participants
@zoq
Member

zoq commented Jun 21, 2018

Remove the random seed from the test cases.

@ShikharJ

This comment has been minimized.

Show comment
Hide comment
@ShikharJ

ShikharJ Jun 21, 2018

Member

@zoq Why is this needed?

Member

ShikharJ commented Jun 21, 2018

@zoq Why is this needed?

@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq Jun 21, 2018

Member

It simplifies the debugging process: #1306 (comment)

Member

zoq commented Jun 21, 2018

It simplifies the debugging process: #1306 (comment)

@rcurtin

Sorry for the slow response, looks good to me. I'll go ahead and merge in 3 days unless you'd like to merge it first.

@zoq zoq merged commit a2abf9d into mlpack:master Jun 25, 2018

5 checks passed

Memory Checks
Details
Static Code Analysis Checks Build finished.
Details
Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment