New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid error in local_coordinate_coding #1457

Merged
merged 2 commits into from Jul 3, 2018

Conversation

Projects
None yet
2 participants
@rcurtin
Member

rcurtin commented Jul 2, 2018

I have removed a check that would mean that the user must pass either 'initial_dictionary' or 'input_model' to any call of the program. This makes it impossible to run LCC with a random initial dictionary.

I think this would be sufficient for releasing 3.0.3 as a bugfix, but we can also wait a little if there are more fixes or functionality.

rcurtin added some commits Jul 2, 2018

Remove check that makes LCC unusable in some cases.
This check would mean that the user must pass either 'initial_dictionary' or
'input_model' to any call of the program.  This makes it impossible to run LCC
with a random initial dictionary.
@zoq

zoq approved these changes Jul 2, 2018

Looks good to me, I'll go ahead and merge this in 2 days unless you'd like to merge it now.

About 3.0.3, I guess we could wait another week or so, and see if anything else comes up.

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Jul 3, 2018

Member

Agreed, let's give it a week and see if there is anything else.

Member

rcurtin commented Jul 3, 2018

Agreed, let's give it a week and see if there is anything else.

@rcurtin rcurtin merged commit a336934 into mlpack:master Jul 3, 2018

5 checks passed

Memory Checks
Details
Static Code Analysis Checks Build finished.
Details
Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rcurtin rcurtin deleted the rcurtin:lcc-fix branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment