New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation fields to setup.py.in #1460

Merged
merged 2 commits into from Jul 14, 2018

Conversation

Projects
None yet
2 participants
@rcurtin
Member

rcurtin commented Jul 3, 2018

Also simplify the CXXFLAGS setting process.

I found that these fields were missing from the package uploaded to PyPI back when I packaged mlpack 3.0.0, and today I pushed mlpack 3.0.2 and noticed I needed to modify the script. So it would be a good thing to merge these into master.

If you see any changes that we should make to the documentation please feel free. Here is the PyPI page this results in:

https://pypi.org/project/mlpack3/

We could modify it a bit---for instance, scikit actually loads their entire README into the long description with code like:

with open('README.rst') as f:
  LONG_DESCRIPTION = f.read()

But unless someone explicitly wants me to do that (and it's no problem if anyone does want it), I'll leave it as-is.

Add documentation fields to setup.py.in.
Also simplify the CXXFLAGS setting process.
@zoq

zoq approved these changes Jul 12, 2018

Sorry for the slow response on this one; this looks good to me, and I think this works without including the README.md.

Show outdated Hide outdated src/mlpack/bindings/python/setup.py.in Outdated
@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Jul 14, 2018

Member

Ok, I will go ahead and merge this then. Thanks for the comments. 👍

Member

rcurtin commented Jul 14, 2018

Ok, I will go ahead and merge this then. Thanks for the comments. 👍

@rcurtin rcurtin merged commit 884523d into mlpack:master Jul 14, 2018

5 checks passed

Memory Checks Build finished.
Details
Static Code Analysis Checks Build finished.
Details
Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment