Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add EvaluateWithGradient To FFN and RNN #1467
Looks great to me. I like code deduplication. :) Did you happen to see what the speedup was for this? I'd imagine 10-30% for training of general FFNs.
(Also I guess we could do the same thing for RNNs too? I think the code would be really similar.)
This looks good to me. I'll go ahead and merge this in 2 days to leave time for any other comments. Thanks!