Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hard sigmoid #1776

Merged
merged 1 commit into from Mar 24, 2019

Conversation

Projects
None yet
4 participants
@Bk073
Copy link
Contributor

commented Mar 11, 2019

I wanted to make a review of my work. I have added a hard sigmoid function. Thank you so much

@mlpack-bot

This comment has been minimized.

Copy link

commented Mar 11, 2019

Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:

  • All code should follow the style guide
  • Documentation added for any new functionality
  • Tests added for any new functionality
  • Tests that are added follow the testing guide
  • Headers and license information added to the top of any new code files
  • HISTORY.md updated if the changes are big or user-facing
  • All CI checks should be passing

Thank you again for your contributions! 👍

@zoq zoq removed the s: unanswered label Mar 11, 2019

@Bk073 Bk073 force-pushed the Bk073:add-hard-sigmoid branch from a6bc826 to 6d5fdc2 Mar 12, 2019

@ShikharJ
Copy link
Member

left a comment

Some minor corrections.

@ShikharJ
Copy link
Member

left a comment

Just a minor comment, rest all looks good.

@Bk073 Bk073 force-pushed the Bk073:add-hard-sigmoid branch from c8e385f to 35e417f Mar 22, 2019

@ShikharJ

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

@Bk073 It seems you have also committed the binary files for VSCode? Can you remove them?

@Bk073 Bk073 force-pushed the Bk073:add-hard-sigmoid branch from 35e417f to 932f75f Mar 22, 2019

@Bk073

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@zoq @ShikharJ Please review again. I have squashed the commits and made suggested changes.

@mlpack-bot

mlpack-bot bot approved these changes Mar 22, 2019

Copy link

left a comment

Second approval provided automatically after 24 hours. 👍

* The hard sigmoid function, defined by
*
* @f{eqnarray*}{
* f(x) &=& \min(1, max(0, {0.2 * x + 0.5}) \\

This comment has been minimized.

Copy link
@zoq

zoq Mar 22, 2019

Member

Missing \ before max, also no need to use {} inside the max function. Sorry for being so picky.

@Bk073 Bk073 force-pushed the Bk073:add-hard-sigmoid branch from 932f75f to 71265c3 Mar 23, 2019

@Bk073 Bk073 force-pushed the Bk073:add-hard-sigmoid branch from 71265c3 to ca98f83 Mar 23, 2019

@Bk073

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

@zoq Made suggested changes.

@zoq

zoq approved these changes Mar 24, 2019

Copy link
Member

left a comment

No further comments from my side, thanks for the contribution.

@mlpack-bot

This comment has been minimized.

Copy link

commented Mar 24, 2019

Hello there! Thanks for your contribution. I see that this is your first contribution to mlpack. If you'd like to add your name to the list of contributors in src/mlpack/core.hpp and COPYRIGHT.txt and you haven't already, please feel free to push a change to this PR---or, if it gets merged before you can, feel free to open another PR.

In addition, if you'd like some stickers to put on your laptop, I'd be happy to help get them in the mail for you. Just send an email with your physical mailing address to stickers@mlpack.org, and then one of the mlpack maintainers will put some stickers in an envelope for you. It may take a few weeks to get them, depending on your location. 👍

@ShikharJ ShikharJ merged commit 85e0010 into mlpack:master Mar 24, 2019

6 checks passed

LaTeX Documentation Checks Build finished.
Details
Memory Checks Build finished.
Details
Static Code Analysis Checks Build finished.
Details
Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ShikharJ

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Thanks for the contribution @Bk073!

@Bk073 Bk073 referenced this pull request Apr 8, 2019

Merged

Added contribution name #1851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.