Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hard sigmoid #1776

Merged
merged 1 commit into from Mar 24, 2019
Merged

Add hard sigmoid #1776

merged 1 commit into from Mar 24, 2019

Conversation

Bk073
Copy link
Contributor

@Bk073 Bk073 commented Mar 11, 2019

I wanted to make a review of my work. I have added a hard sigmoid function. Thank you so much

@mlpack-bot
Copy link

mlpack-bot bot commented Mar 11, 2019

Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:

  • All code should follow the style guide
  • Documentation added for any new functionality
  • Tests added for any new functionality
  • Tests that are added follow the testing guide
  • Headers and license information added to the top of any new code files
  • HISTORY.md updated if the changes are big or user-facing
  • All CI checks should be passing

Thank you again for your contributions! 👍

zoq
zoq reviewed Mar 11, 2019
View reviewed changes
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/tests/activation_functions_test.cpp Outdated Show resolved Hide resolved
@zoq zoq removed the s: unanswered label Mar 11, 2019
ShikharJ
ShikharJ reviewed Mar 15, 2019
View reviewed changes
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/tests/activation_functions_test.cpp Outdated Show resolved Hide resolved
ShikharJ
ShikharJ requested changes Mar 19, 2019
View reviewed changes
Copy link
Member

@ShikharJ ShikharJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor corrections.

src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Show resolved Hide resolved
ShikharJ
ShikharJ approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@ShikharJ ShikharJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, rest all looks good.

src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated Show resolved Hide resolved
@ShikharJ
Copy link
Member

@Bk073 It seems you have also committed the binary files for VSCode? Can you remove them?

@Bk073
Copy link
Contributor Author

Bk073 commented Mar 22, 2019 •
edited

@zoq @ShikharJ Please review again. I have squashed the commits and made suggested changes.

mlpack-bot[bot]
mlpack-bot bot approved these changes Mar 22, 2019
View reviewed changes
Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

zoq
zoq reviewed Mar 22, 2019
View reviewed changes
src/mlpack/methods/ann/activation_functions/hard_sigmoid_function.hpp Outdated
* The hard sigmoid function, defined by
*
* @f{eqnarray*}{
* f(x) &=& \min(1, max(0, {0.2 * x + 0.5}) \\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing \ before max, also no need to use {} inside the max function. Sorry for being so picky.

@Bk073
Copy link
Contributor Author

Bk073 commented Mar 23, 2019

@zoq Made suggested changes.

zoq
zoq approved these changes Mar 24, 2019
View reviewed changes
Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further comments from my side, thanks for the contribution.

@mlpack-bot
Copy link

mlpack-bot bot commented Mar 24, 2019

Hello there! Thanks for your contribution. I see that this is your first contribution to mlpack. If you'd like to add your name to the list of contributors in src/mlpack/core.hpp and COPYRIGHT.txt and you haven't already, please feel free to push a change to this PR---or, if it gets merged before you can, feel free to open another PR.

In addition, if you'd like some stickers to put on your laptop, I'd be happy to help get them in the mail for you. Just send an email with your physical mailing address to stickers@mlpack.org, and then one of the mlpack maintainers will put some stickers in an envelope for you. It may take a few weeks to get them, depending on your location. 👍

@ShikharJ ShikharJ merged commit 85e0010 into mlpack:master Mar 24, 2019
@ShikharJ
Copy link
Member

Thanks for the contribution @Bk073!

@Bk073 Bk073 mentioned this pull request Apr 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcurtin rcurtin rcurtin left review comments

@ShikharJ ShikharJ ShikharJ approved these changes

@zoq zoq zoq approved these changes

@mlpack-bot mlpack-bot[bot] mlpack-bot approved these changes

Assignees
No one assigned
Labels
c: methods s: needs review t: added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bk073 @ShikharJ @rcurtin @zoq