Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ensmallen headers when downloaded during build. #1900

Merged
merged 1 commit into from May 23, 2019

Conversation

Projects
None yet
2 participants
@rcurtin
Copy link
Member

commented May 21, 2019

While reading #1866 I realized that if CMake downloads ensmallen for the build, if the user installs mlpack it only installs the mlpack headers, meaning they can't ever build anything against mlpack unless they go and also install ensmallen.

This PR fixes that by having CMake install ensmallen, but only when it is downloaded during the build process because it is not available on the system.

@zoq

zoq approved these changes May 21, 2019

Copy link
Member

left a comment

Ohh nice catch. This looks good to me.

@mlpack-bot

mlpack-bot bot approved these changes May 22, 2019

Copy link

left a comment

Second approval provided automatically after 24 hours. 👍

@rcurtin rcurtin merged commit 44d09d8 into mlpack:master May 23, 2019

6 checks passed

LaTeX Documentation Checks Build finished.
Details
Memory Checks Build finished.
Details
Static Code Analysis Checks Build finished.
Details
Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rcurtin rcurtin deleted the rcurtin:ensmallen-install branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.