Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve calculation of accuracy #1922

Merged
merged 2 commits into from Jun 16, 2019

Conversation

@Yashwants19
Copy link
Contributor

commented Jun 13, 2019

No description provided.

@rcurtin

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Can you add a description of what the problem is and how you're fixing it to the PR please? 👍

@Yashwants19

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

Hi @rcurtin previously when I was enabling -p for getting prediction and also at same time -L for setting test_labels than I was getting Nan at the place of accuracy. May be because of std::move(predictions)

@Yashwants19

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

Sorry Earlier I didn't provide the description.

Copy link
Member

left a comment

That really looks like a bug. Thanks for handling it. No, comments from my side.

@mlpack-bot
mlpack-bot bot approved these changes Jun 14, 2019
Copy link

left a comment

Second approval provided automatically after 24 hours. 👍

@rcurtin rcurtin merged commit e08b0c0 into mlpack:master Jun 16, 2019
6 checks passed
6 checks passed
LaTeX Documentation Checks Build finished.
Details
Memory Checks Build finished.
Details
Static Code Analysis Checks Build finished.
Details
Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rcurtin

This comment has been minimized.

Copy link
Member

commented Jun 16, 2019

Nice fix, thanks! I updated HISTORY.md during merge in 7824ae0.

@Yashwants19 Yashwants19 deleted the Yashwants19:Softmax branch Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.