Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
FastMKS segfault fix #1986
I dug into #1767 and found that the issue is actually not the fact that the hyperbolic tangent kernel is only conditionally positive definite. Instead, for the optdigits dataset, the issue is that the dot product between each point is sufficiently large that every kernel evaluation is identical---meaning that the distance between points is always 0.
This then means that the cover tree gets built in a weird way that is actually invalid. So I fixed this bug in e584aea.
While I was in there, I also made the FastMKS binding check for a valid value of k, if it is passed, and added a test for it. And I hid the