Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Armadillo to minimum version of 8.400.0. #2015

Merged
merged 9 commits into from Sep 14, 2019

Conversation

@rcurtin
Copy link
Member

commented Sep 11, 2019

This should fix the Travis build, updates the documentation, and should also remove some now-unnecessary code.

.travis.yml Outdated
@@ -9,7 +9,7 @@ matrix:
- sudo apt-get update
- sudo apt-get install -y --allow-unauthenticated libopenblas-dev liblapack-dev g++ libboost-all-dev python-pip cython python-numpy python-pandas
- sudo pip install --upgrade --ignore-installed setuptools cython
- curl https://ftp.fau.de/macports/distfiles/armadillo/armadillo-6.500.5.tar.gz | tar xvz && cd armadillo*
- curl https://ftp.fau.de/macports/distfiles/armadillo/armadillo-8.400.0.tar.xz | tar xv && cd armadillo*

This comment has been minimized.

Copy link
@zoq

zoq Sep 11, 2019

Member

In ensmallen I used:

curl https://ftp.fau.de/macports/distfiles/armadillo/armadillo-8.400.0.tar.xz | tar -xvJ && cd armadillo*;

and also installed xz-utils not sure that step is necessary.

This comment has been minimized.

Copy link
@rcurtin

rcurtin Sep 12, 2019

Author Member

Yeah, I made the same change here... let's see if it works. I don't mind installing xz-utils even if it's not needed. :)

@zoq zoq removed the s: unanswered label Sep 11, 2019
@zoq
zoq approved these changes Sep 12, 2019
Copy link
Member

left a comment

Looks good to me.

@rcurtin rcurtin added this to the mlpack 3.2.0 milestone Sep 13, 2019
@mlpack-bot
mlpack-bot bot approved these changes Sep 13, 2019
Copy link

left a comment

Second approval provided automatically after 24 hours. 👍

@KimSangYeon-DGU

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

Looks good to me.

@zoq zoq merged commit a6040b7 into mlpack:master Sep 14, 2019
6 checks passed
6 checks passed
LaTeX Documentation Checks Build finished.
Details
Memory Checks Build finished.
Details
Static Code Analysis Checks Build finished.
Details
Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zoq

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

Nice, let's restart some travis builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.