Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Armadillo to minimum version of 8.400.0 #2029

Merged
merged 1 commit into from Sep 27, 2019

Conversation

@jeffin143
Copy link
Contributor

commented Sep 24, 2019

@rcurtin , Did you on purpose leave arma version in CMake, if so please go ahead and close it :)

@jeffin143

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

Travis , just timed out :)

@rcurtin

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

Nice catch, thanks. Looks like I'll have to upgrade Armadillo on some of the build systems; let me do that now...

@zoq
zoq approved these changes Sep 24, 2019
Copy link
Member

left a comment

Looks good to me.

@jeffin143 jeffin143 requested a review from zoq Sep 24, 2019
@zoq
zoq approved these changes Sep 24, 2019
Copy link
Member

left a comment

Nice catch, looks good to me.

@mlpack-bot
mlpack-bot bot approved these changes Sep 25, 2019
Copy link

left a comment

Second approval provided automatically after 24 hours. 👍

@rcurtin

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

@mlpack-jenkins test this please

@rcurtin

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

There we go, got the build servers working with the right version of Armadillo.

@rcurtin rcurtin merged commit 7f95156 into mlpack:master Sep 27, 2019
6 checks passed
6 checks passed
LaTeX Documentation Checks Build finished.
Details
Memory Checks Build finished.
Details
Static Code Analysis Checks Build finished.
Details
Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rcurtin

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

Thanks @jeffin143! 👍

@jeffin143 jeffin143 deleted the jeffin143:bump-arma branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.