Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce ensmallen version check #2032

Merged
merged 3 commits into from Sep 28, 2019

Conversation

@rcurtin
Copy link
Member

commented Sep 26, 2019

@jeffin143 noticed in IRC that if even old ensmallen versions are installed, CMake will still successfully configure (but then fail to build).

After a little while of digging I discovered that one single character is the culprit:

Since we call find_package(Ensmallen ...), which calls FindEnsmallen.cmake, we must use the name Ensmallen not ensmallen in the call to find_package_handle_standard_args(), otherwise the version check is not enforced.

@zoq

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

Hm, not sure should we release a patch (mlpack 3.2.1)?

@jeffin143

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2019

Hm, not sure should we release a patch (mlpack 3.2.1)?

I think we should ! ,

Also we should merge armadillo update pr and then release may be

@zoq
zoq approved these changes Sep 27, 2019
Copy link
Member

left a comment

Looks good to me, important fix.

@rcurtin

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2019

Sure, easy enough to issue a patch release.

@mlpack-bot
mlpack-bot bot approved these changes Sep 28, 2019
Copy link

left a comment

Second approval provided automatically after 24 hours. 👍

@zoq zoq merged commit c996ba5 into mlpack:master Sep 28, 2019
0 of 6 checks passed
0 of 6 checks passed
LaTeX Documentation Checks Build started for merge commit.
Details
Memory Checks Build triggered for merge commit.
Details
Static Code Analysis Checks Build triggered for merge commit.
Details
Style Checks Build started for merge commit.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@zoq

This comment has been minimized.

Copy link
Member

commented Sep 28, 2019

Great, two more to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.