Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Simplify CMake for Armadillo and its Dependencies #2247
I'm starting various testing. It seems to work fine on the mac os machine that I inexplicably have with armadillo configured both with and without wrapper. That said, I have to test at least with windows before I mark this ready for review.
I think that some people wanted to help with this, namely @knakul853 ... who I now realize may be working on the same thing in parallel... hopefuly I haven't wasted much of their time.
I'll update with more test results. I guess I should test bindings too, even though this shouldn't touch them.
@birm great work I didn't notice you are working...let me know if I can help anyway :)
rcurtin left a comment •
Awesome work @birm, it'll be nice to remove that bit of code from the main
(edit: I read the diff wrong. The comments below aren't wrong, but they're not relevant...)
A couple comments though---I see that
Specifically, you can see that that CMake script doesn't actually look in
The main difference between the
(end irrelevant comments)
When I wrote this originally, I used all the
Ok, looking good to me. I believe we have to update some documentation though; it looks like the Windows build guide in