New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusion in error message #504

Merged
merged 1 commit into from Jan 19, 2016

Conversation

Projects
None yet
2 participants
@andyfangdz
Contributor

andyfangdz commented Jan 19, 2016

The error message was "missing output_model",
while the variable used for detecting it was "outputFile",
which refers to the testing output, rather than the model output.

Fix confusion in error message
The error message was "missing output_model",
while the variable used for detecting it was "outputFile",
which refers to the testing output, rather than the model output.
@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Jan 19, 2016

Member

Nice catch, thanks! This is a result of some earlier refactoring.

Member

rcurtin commented Jan 19, 2016

Nice catch, thanks! This is a result of some earlier refactoring.

rcurtin added a commit that referenced this pull request Jan 19, 2016

Merge pull request #504 from andyfangdz/patch-1
Fix confusion in error message

@rcurtin rcurtin merged commit b29997d into mlpack:master Jan 19, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@rcurtin rcurtin added this to the mlpack 2.0.1 milestone Jan 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment