New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GetParam<>(parameterName) per marcos #505

Merged
merged 1 commit into from Jan 22, 2016

Conversation

Projects
None yet
2 participants
@andyfangdz
Contributor

andyfangdz commented Jan 22, 2016

PARAM_STRING("input_model_file", "File containing existing model (parameters).",
    "m", "");
PARAM_STRING("output_model_file", "File to save trained logistic regression "
    "model to.", "M", "");

v.s.

const string inputModelFile = CLI::GetParam<string>("input_model");
const string outputModelFile = CLI::GetParam<string>("output_model");
Update GetParam<>(parameterName) per marcos
```
PARAM_STRING("input_model_file", "File containing existing model (parameters).",
    "m", "");
PARAM_STRING("output_model_file", "File to save trained logistic regression "
    "model to.", "M", "");
```
v.s.
```
const string inputModelFile = CLI::GetParam<string>("input_model");
const string outputModelFile = CLI::GetParam<string>("output_model");
```
@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Jan 22, 2016

Member

Wow, I thought I checked all this before the 2.0.0 release, but it looks like I missed some things. This highlights the need for a good command-line program testing framework (maybe I'll get to it someday). Thanks for the fix!

Member

rcurtin commented Jan 22, 2016

Wow, I thought I checked all this before the 2.0.0 release, but it looks like I missed some things. This highlights the need for a good command-line program testing framework (maybe I'll get to it someday). Thanks for the fix!

rcurtin added a commit that referenced this pull request Jan 22, 2016

Merge pull request #505 from andyfangdz/patch-1
Update GetParam<>(parameterName) per marcos

@rcurtin rcurtin merged commit e6bbde6 into mlpack:master Jan 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rcurtin rcurtin added this to the mlpack 2.0.1 milestone Jan 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment