Update GetParam<>(parameterName) per marcos #505

Merged
merged 1 commit into from Jan 22, 2016

Projects

None yet

2 participants

@andyfangdz
Contributor
PARAM_STRING("input_model_file", "File containing existing model (parameters).",
    "m", "");
PARAM_STRING("output_model_file", "File to save trained logistic regression "
    "model to.", "M", "");

v.s.

const string inputModelFile = CLI::GetParam<string>("input_model");
const string outputModelFile = CLI::GetParam<string>("output_model");
@andyfangdz andyfangdz Update GetParam<>(parameterName) per marcos
```
PARAM_STRING("input_model_file", "File containing existing model (parameters).",
    "m", "");
PARAM_STRING("output_model_file", "File to save trained logistic regression "
    "model to.", "M", "");
```
v.s.
```
const string inputModelFile = CLI::GetParam<string>("input_model");
const string outputModelFile = CLI::GetParam<string>("output_model");
```
cd15763
@rcurtin
Member
rcurtin commented Jan 22, 2016

Wow, I thought I checked all this before the 2.0.0 release, but it looks like I missed some things. This highlights the need for a good command-line program testing framework (maybe I'll get to it someday). Thanks for the fix!

@rcurtin rcurtin merged commit e6bbde6 into mlpack:master Jan 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rcurtin rcurtin added this to the mlpack 2.0.1 milestone Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment