New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMAKE_CURRENT_SOURCE_DIR during files generation. #512

Merged
merged 1 commit into from Feb 1, 2016

Conversation

Projects
None yet
2 participants
@theranger
Contributor

theranger commented Jan 30, 2016

I tried to use mlpack as a submodule of my project. Building such setup failed since some files were generated outside of mlpack source tree.

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Feb 1, 2016

Member

Ah, now I know the importance of the difference between CMAKE_SOURCE_DIR and CMAKE_CURRENT_SOURCE_DIR. Thanks!

Member

rcurtin commented Feb 1, 2016

Ah, now I know the importance of the difference between CMAKE_SOURCE_DIR and CMAKE_CURRENT_SOURCE_DIR. Thanks!

rcurtin added a commit that referenced this pull request Feb 1, 2016

Merge pull request #512 from theranger/master
Use CMAKE_CURRENT_SOURCE_DIR during files generation.

@rcurtin rcurtin merged commit 3b3a8a1 into mlpack:master Feb 1, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Feb 4, 2016

Member

@theranger: Hey, I'm sorry I forgot about this when I merged this PR; I'd be happy to add your name to the list of authors in src/mlpack/core.hpp and COPYRIGHT.txt; would you want me to do that? If so, let me know what name/email you'd like me to use.

Member

rcurtin commented Feb 4, 2016

@theranger: Hey, I'm sorry I forgot about this when I merged this PR; I'd be happy to add your name to the list of authors in src/mlpack/core.hpp and COPYRIGHT.txt; would you want me to do that? If so, let me know what name/email you'd like me to use.

@theranger

This comment has been minimized.

Show comment
Hide comment
@theranger

theranger Feb 7, 2016

Contributor

Well, it was rather a minor change. But it would be fine by me. Please use Ivari Horm (ivari@risk.ee).

Contributor

theranger commented Feb 7, 2016

Well, it was rather a minor change. But it would be fine by me. Please use Ivari Horm (ivari@risk.ee).

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Feb 8, 2016

Member

I set the cutoff at "more than 0 characters contributed to git master" to keep things simple, so, I've added your name to the contributors in 9f1d08a. Thanks! If you have any more issues feel free to submit more PRs. :)

Member

rcurtin commented Feb 8, 2016

I set the cutoff at "more than 0 characters contributed to git master" to keep things simple, so, I've added your name to the contributors in 9f1d08a. Thanks! If you have any more issues feel free to submit more PRs. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment