Use CMAKE_CURRENT_SOURCE_DIR during files generation. #512

Merged
merged 1 commit into from Feb 1, 2016

Projects

None yet

2 participants

@theranger
Contributor

I tried to use mlpack as a submodule of my project. Building such setup failed since some files were generated outside of mlpack source tree.

@rcurtin
Member
rcurtin commented Feb 1, 2016

Ah, now I know the importance of the difference between CMAKE_SOURCE_DIR and CMAKE_CURRENT_SOURCE_DIR. Thanks!

@rcurtin rcurtin merged commit 3b3a8a1 into mlpack:master Feb 1, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@rcurtin
Member
rcurtin commented Feb 4, 2016

@theranger: Hey, I'm sorry I forgot about this when I merged this PR; I'd be happy to add your name to the list of authors in src/mlpack/core.hpp and COPYRIGHT.txt; would you want me to do that? If so, let me know what name/email you'd like me to use.

@theranger
Contributor

Well, it was rather a minor change. But it would be fine by me. Please use Ivari Horm (ivari@risk.ee).

@rcurtin
Member
rcurtin commented Feb 8, 2016

I set the cutoff at "more than 0 characters contributed to git master" to keep things simple, so, I've added your name to the contributors in 9f1d08a. Thanks! If you have any more issues feel free to submit more PRs. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment