New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing function argument #636

Merged
merged 1 commit into from Jul 1, 2016

Conversation

Projects
None yet
2 participants
@peter-lehner
Contributor

peter-lehner commented May 4, 2016

The probabilities variable is not passed to the fitter when running multiple trials.

Added missing function argument
The probabilities variable is not passed to the fitter when running multiple trials.
@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin May 9, 2016

Member

Hi Peter,

Thanks for the contribution. I think this does indeed fix an issue, but it looks like it breaks one of the HMM test cases. Maybe the test case is wrong. I hope to have a chance to look into it today or in the next couple days and I will update you with what I find out.

Thanks for taking the time to report this!

Member

rcurtin commented May 9, 2016

Hi Peter,

Thanks for the contribution. I think this does indeed fix an issue, but it looks like it breaks one of the HMM test cases. Maybe the test case is wrong. I hope to have a chance to look into it today or in the next couple days and I will update you with what I find out.

Thanks for taking the time to report this!

@rcurtin rcurtin merged commit 36d731b into mlpack:master Jul 1, 2016

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Jul 1, 2016

Member

Well it was more than a day or two until I could look into it, but yes, the test case was written incorrectly. I've merged your fix and a fix for the test in a05072a, and added your name to the list of contributors.

Thanks very much for the patch!

Member

rcurtin commented Jul 1, 2016

Well it was more than a day or two until I could look into it, but yes, the test case was written incorrectly. I've merged your fix and a fix for the test in a05072a, and added your name to the list of contributors.

Thanks very much for the patch!

@peter-lehner

This comment has been minimized.

Show comment
Hide comment
@peter-lehner

peter-lehner Jul 4, 2016

Contributor

Hi Ryan, glad I could help! Best wishes.

Contributor

peter-lehner commented Jul 4, 2016

Hi Ryan, glad I could help! Best wishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment