Added missing function argument #636

Merged
merged 1 commit into from Jul 1, 2016

Projects

None yet

2 participants

@peter-lehner
Contributor

The probabilities variable is not passed to the fitter when running multiple trials.

@peter-lehner peter-lehner Added missing function argument
The probabilities variable is not passed to the fitter when running multiple trials.
fddb236
@rcurtin
Member
rcurtin commented May 9, 2016

Hi Peter,

Thanks for the contribution. I think this does indeed fix an issue, but it looks like it breaks one of the HMM test cases. Maybe the test case is wrong. I hope to have a chance to look into it today or in the next couple days and I will update you with what I find out.

Thanks for taking the time to report this!

@rcurtin rcurtin merged commit 36d731b into mlpack:master Jul 1, 2016

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@rcurtin
Member
rcurtin commented Jul 1, 2016 edited

Well it was more than a day or two until I could look into it, but yes, the test case was written incorrectly. I've merged your fix and a fix for the test in a05072a, and added your name to the list of contributors.

Thanks very much for the patch!

@peter-lehner
Contributor

Hi Ryan, glad I could help! Best wishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment